commit a68386b9fffea123b568538dfe34776a89c14492
author Rebecca Stambler <rstambler@golang.org> Sat Mar 30 12:19:12 2019 -0400
committer Rebecca Stambler <rstambler@golang.org> Sat Mar 30 16:34:40 2019 +0000
tree 1e421201629f003758241d05cb70f584cfd50c46
parent 1cd2f21070ecb547260f77e509ce60906a51b4ca

go/packages: add NeedTypesSizes to LoadTypes

This change moves the NeedTypesSizes bit to LoadTypes instead of LoadSyntax.

Fixes golang/go#31163

Change-Id: Icaf16639202533fbb2190756a325b36d8ac9251c
Reviewed-on: https://go-review.googlesource.com/c/tools/+/170016
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>

go/packages/packages.go

diff --git a/go/packages/packages.go b/go/packages/packages.go
index 36e54a3..7d0198f 100644
--- a/go/packages/packages.go
+++ b/go/packages/packages.go
@@ -88,14 +88,14 @@
 
 	// LoadTypes adds type information for package-level
 	// declarations in the packages matching the patterns.
-	// Package fields added: Types, Fset, and IllTyped.
+	// Package fields added: Types, TypesSizes, Fset, and IllTyped.
 	// This mode uses type information provided by the build system when
 	// possible, and may fill in the ExportFile field.
-	LoadTypes = LoadImports | NeedTypes
+	LoadTypes = LoadImports | NeedTypes | NeedTypesSizes
 
 	// LoadSyntax adds typed syntax trees for the packages matching the patterns.
 	// Package fields added: Syntax, and TypesInfo, for direct pattern matches only.
-	LoadSyntax = LoadTypes | NeedSyntax | NeedTypesInfo | NeedTypesSizes
+	LoadSyntax = LoadTypes | NeedSyntax | NeedTypesInfo
 
 	// LoadAllSyntax adds typed syntax trees for the packages matching the patterns
 	// and all dependencies.

go/packages/packages_test.go

diff --git a/go/packages/packages_test.go b/go/packages/packages_test.go
index bff6409..85a6b31 100644
--- a/go/packages/packages_test.go
+++ b/go/packages/packages_test.go
@@ -569,6 +569,8 @@
 			continue
 		} else if !p.Types.Complete() {
 			t.Errorf("incomplete types.Package for %s", p)
+		} else if p.TypesSizes == nil {
+			t.Errorf("TypesSizes is not filled in for %s", p)
 		}
 
 	}