| commit | 9f230b5628613e4b8627cca0e69d4f5fd46db7d0 | [log] [tgz] |
|---|---|---|
| author | Suzy Mueller <suzmue@golang.org> | Tue Jun 08 16:44:48 2021 -0400 |
| committer | Suzy Mueller <suzmue@golang.org> | Wed Jun 09 14:15:26 2021 +0000 |
| tree | 5aae5d971b0c3a88652e6caa73e70e93cfa9e1f7 | |
| parent | 4e58f8f09d6d4762e6f22c0ca9ba3eba103c2ad9 [diff] |
internal/lsp: fix extract bug choosing available identifiers When choosing variable names, extract makes sure that the chosen name does not conflict with any existing variables. By avoiding these conflicts, we may actually have a conflict with the other names we are choosing. This change removes this conflict by sending the next index to use as the suffix of the function name. Change-Id: Icd81b67db29db2503e214d24ec19ca1065cda090 Reviewed-on: https://go-review.googlesource.com/c/tools/+/326111 Trust: Suzy Mueller <suzmue@golang.org> Run-TryBot: Suzy Mueller <suzmue@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Go Bot <gobot@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.