tree 5aae5d971b0c3a88652e6caa73e70e93cfa9e1f7
parent 4e58f8f09d6d4762e6f22c0ca9ba3eba103c2ad9
author Suzy Mueller <suzmue@golang.org> 1623185088 -0400
committer Suzy Mueller <suzmue@golang.org> 1623248126 +0000

internal/lsp: fix extract bug choosing available identifiers

When choosing variable names, extract makes sure that the chosen
name does not conflict with any existing variables. By avoiding these
conflicts, we may actually have a conflict with the other names we
are choosing. This change removes this conflict by sending the next
index to use as the suffix of the function name.

Change-Id: Icd81b67db29db2503e214d24ec19ca1065cda090
Reviewed-on: https://go-review.googlesource.com/c/tools/+/326111
Trust: Suzy Mueller <suzmue@golang.org>
Run-TryBot: Suzy Mueller <suzmue@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>