commit 8bc39b98806018cdd1163c436250fa9b8048f834
author Ian Cottrell <iancottrell@google.com> Fri Dec 07 13:29:09 2018 -0500
committer Ian Cottrell <iancottrell@google.com> Fri Dec 07 18:38:36 2018 +0000
tree 4ea9302edf6936b41cbe478f82849a75a6f22f77
parent bcd4e47d02889ebbc25c9f4bf3d27e4124b0bf9d

go/packages: an empty overlay does not force source mode

we check length of the map, and a non empty map forces source mode.

Change-Id: Id314ad87b96d9154198122586fd8672a70c5ca95
Reviewed-on: https://go-review.googlesource.com/c/153198
Run-TryBot: Ian Cottrell <iancottrell@google.com>
Reviewed-by: Michael Matloob <matloob@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

go/packages/packages.go

diff --git a/go/packages/packages.go b/go/packages/packages.go
index 81e5b82..7a4c942 100644
--- a/go/packages/packages.go
+++ b/go/packages/packages.go
@@ -432,7 +432,7 @@
 				ld.Mode >= LoadTypes && rootIndex >= 0,
 			needsrc: ld.Mode >= LoadAllSyntax ||
 				ld.Mode >= LoadSyntax && rootIndex >= 0 ||
-				ld.Overlay != nil || // Overlays can invalidate export data. TODO(matloob): make this check fine-grained based on dependencies on overlaid files
+				len(ld.Overlay) > 0 || // Overlays can invalidate export data. TODO(matloob): make this check fine-grained based on dependencies on overlaid files
 				pkg.ExportFile == "" && pkg.PkgPath != "unsafe",
 		}
 		ld.pkgs[lpkg.ID] = lpkg