| commit | 84cebe10344f1cd161b47a7087b7979c67beab95 | [log] [tgz] |
|---|---|---|
| author | Michael Matloob <matloob@golang.org> | Wed Jan 15 14:54:51 2020 -0500 |
| committer | Michael Matloob <matloob@golang.org> | Thu Jan 16 22:59:55 2020 +0000 |
| tree | 5ce964da67a9651d514f07bb91a427a8defb9bad | |
| parent | 28ed04f8828615ef8bc15bd089501b6d3b560421 [diff] |
go/packages: fix incorrect needtypes and needsrcs logic This logic is really fiddly and I'm not really 100% sure it's right, though I've thought about it for quite abit (and added comments to help me reason through it). Also always request CompiledGoFiles when NeedTypes is true because we might need to fall back to loading from source when type data is incorrect. Fixes golang/go#36441 Fixes golang/go#36547 Change-Id: I1cc27ca2e4401a9abc8502990b0da7d0480f6f84 Reviewed-on: https://go-review.googlesource.com/c/tools/+/214943 Run-TryBot: Michael Matloob <matloob@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.