tree 5ce964da67a9651d514f07bb91a427a8defb9bad
parent 28ed04f8828615ef8bc15bd089501b6d3b560421
author Michael Matloob <matloob@golang.org> 1579118091 -0500
committer Michael Matloob <matloob@golang.org> 1579215595 +0000

go/packages: fix incorrect needtypes and needsrcs logic

This logic is really fiddly and I'm not really 100% sure it's right, though
I've thought about it for quite abit (and added comments to help me reason
through it).

Also always request CompiledGoFiles when NeedTypes is true because we might
need to fall back to loading from source when type data is incorrect.

Fixes golang/go#36441
Fixes golang/go#36547

Change-Id: I1cc27ca2e4401a9abc8502990b0da7d0480f6f84
Reviewed-on: https://go-review.googlesource.com/c/tools/+/214943
Run-TryBot: Michael Matloob <matloob@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>