internal/lsp: fix the debug info pages There was a dealock introduced in cl/190737 on all the internal structure debug pages. The object getters all protect with the mutex already, it should not also be done in the outer Render function Change-Id: I5c85dc8e2ec489e59ca5a80128f2649dd7753983 Reviewed-on: https://go-review.googlesource.com/c/tools/+/205165 Run-TryBot: Ian Cottrell <iancottrell@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
diff --git a/internal/lsp/debug/serve.go b/internal/lsp/debug/serve.go index 0a93527..c62a525 100644 --- a/internal/lsp/debug/serve.go +++ b/internal/lsp/debug/serve.go
@@ -248,8 +248,6 @@ func Render(tmpl *template.Template, fun func(*http.Request) interface{}) func(http.ResponseWriter, *http.Request) { return func(w http.ResponseWriter, r *http.Request) { - mu.Lock() - defer mu.Unlock() var data interface{} if fun != nil { data = fun(r)