internal/lsp: enable go-diff by default
Also, fix a minor staticcheck warning.
Change-Id: Ic500215dac7985a9d8a7189aea4e1be7b20f7780
Reviewed-on: https://go-review.googlesource.com/c/tools/+/204560
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
Reviewed-by: Ian Cottrell <iancottrell@google.com>
diff --git a/internal/lsp/cache/check.go b/internal/lsp/cache/check.go
index 70416ad..fb7772e 100644
--- a/internal/lsp/cache/check.go
+++ b/internal/lsp/cache/check.go
@@ -117,10 +117,7 @@
}
// Make sure all of the depList are sorted.
- var depList []packageID
- for _, id := range m.deps {
- depList = append(depList, id)
- }
+ depList := append([]packageID{}, m.deps...)
sort.Slice(depList, func(i, j int) bool {
return depList[i] < depList[j]
})
diff --git a/internal/lsp/source/options.go b/internal/lsp/source/options.go
index 6f02651..8a00930 100644
--- a/internal/lsp/source/options.go
+++ b/internal/lsp/source/options.go
@@ -68,6 +68,7 @@
},
ComputeEdits: myers.ComputeEdits,
Analyzers: defaultAnalyzers,
+ GoDiff: true,
}
)
