commit 5794f8bd7a57a49a8c82124c0ee90c0c2d22ca0a
author Pontus Leitzler <leitzler@gmail.com> Wed Oct 28 23:04:07 2020 +0100
committer Rebecca Stambler <rstambler@golang.org> Wed Nov 11 21:33:28 2020 +0000
tree de2e45f7472dc9267d76412271ab9536e6ebca44
parent 69daaf961d656fa9386db3c8b1d77c4295e82947

internal/lsp: trim progress report messages

Progress reporting has three different kinds, "begin", "report" and
"end". Each of them comes with a text message attached.

The "report" kind is sometimes raw output, for example from go test, so
the output could end with a newline.

This change trims "report" messages to ensure consistency with "begin"
and "end" that doesn't end with a newline.

Change-Id: I779dc41fdf3f6281d9d44f64e9cee9bbcde0b4cd
Reviewed-on: https://go-review.googlesource.com/c/tools/+/266078
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Daniel Martí <mvdan@mvdan.cc>
Trust: Rebecca Stambler <rstambler@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>

internal/lsp/progress.go

diff --git a/internal/lsp/progress.go b/internal/lsp/progress.go
index 4d18fd8..a8894f8 100644
--- a/internal/lsp/progress.go
+++ b/internal/lsp/progress.go
@@ -8,6 +8,7 @@
 	"context"
 	"math/rand"
 	"strconv"
+	"strings"
 	"sync"
 
 	"golang.org/x/tools/internal/event"
@@ -176,6 +177,7 @@
 		// to send incremental messages.
 		return
 	}
+	message = strings.TrimSuffix(message, "\n")
 	err := wd.client.Progress(wd.ctx, &protocol.ProgressParams{
 		Token: wd.token,
 		Value: &protocol.WorkDoneProgressReport{