| commit | 561a9be6790a1ca809a22901771203c0d0f438ef | [log] [tgz] |
|---|---|---|
| author | Alan Donovan <adonovan@google.com> | Wed Jan 18 14:43:08 2023 -0500 |
| committer | Alan Donovan <adonovan@google.com> | Wed Jan 18 20:59:19 2023 +0000 |
| tree | e4c8856fea4cdb3e50e0408e04e32b54abe8dff8 | |
| parent | 9682b0d473741bd4b0b403887d16e1b7b1e09e83 [diff] |
gopls/internal/lsp/filecache: actually delete files This change fixes an embarrassing blunder: the filename we gave to os.Rename was absolutized twice (goplsDir+goplsDir+path), so of course it was not found. The error was rightly ignored, but this meant the bug was undetected. CI builder machines filled their disks. Also, this change causes filecache's GC to delete files older than maxAge as soon as it encounters them, instead of in the second pass over the sorted list of all files in the cache. This should allow short-lived processes (e.g. tests) to make progress on garbage collection. Though this now seems like a distinctly third-order effect compared to... not deleting files at all. Also: - don't delay between stats after deleting files based on age. - reduce the statDelay to 100us (was 1ms). Scanning a file tree on macOS is already very slow, at least on my Google-issued machine. - reduce maxAge to 5 days (was 7), which should still tide most users over a long weekend. Fixes golang/go#57900 Change-Id: I053f2891d6c52c94f4d5dd18903280dff2282eab Reviewed-on: https://go-review.googlesource.com/c/tools/+/462597 Reviewed-by: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> Run-TryBot: Alan Donovan <adonovan@google.com>
This repository provides the golang.org/x/tools module, comprising various tools and packages mostly for static analysis of Go programs, some of which are listed below. Use the “Go reference” link above for more information about any package.
It also contains the golang.org/x/tools/gopls module, whose root package is a language-server protocol (LSP) server for Go. An LSP server analyses the source code of a project and responds to requests from a wide range of editors such as VSCode and Vim, allowing them to support IDE-like functionality.
Selected commands:
cmd/goimports formats a Go program like go fmt and additionally inserts import statements for any packages required by the file after it is edited.cmd/callgraph prints the call graph of a Go program.cmd/digraph is a utility for manipulating directed graphs in textual notation.cmd/stringer generates declarations (including a String method) for “enum” types.cmd/toolstash is a utility to simplify working with multiple versions of the Go toolchain.These commands may be fetched with a command such as
go install golang.org/x/tools/cmd/goimports@latest
Selected packages:
go/ssa provides a static single-assignment form (SSA) intermediate representation (IR) for Go programs, similar to a typical compiler, for use by analysis tools.
go/packages provides a simple interface for loading, parsing, and type checking a complete Go program from source code.
go/analysis provides a framework for modular static analysis of Go programs.
go/callgraph provides call graphs of Go programs using a variety of algorithms with different trade-offs.
go/ast/inspector provides an optimized means of traversing a Go parse tree for use in analysis tools.
go/cfg provides a simple control-flow graph (CFG) for a Go function.
go/expect reads Go source files used as test inputs and interprets special comments within them as queries or assertions for testing.
go/gcexportdata and go/gccgoexportdata read and write the binary files containing type information used by the standard and gccgo compilers.
go/types/objectpath provides a stable naming scheme for named entities (“objects”) in the go/types API.
Numerous other packages provide more esoteric functionality.
This repository uses Gerrit for code changes. To learn how to submit changes, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.