tree e4c8856fea4cdb3e50e0408e04e32b54abe8dff8
parent 9682b0d473741bd4b0b403887d16e1b7b1e09e83
author Alan Donovan <adonovan@google.com> 1674070988 -0500
committer Alan Donovan <adonovan@google.com> 1674075559 +0000

gopls/internal/lsp/filecache: actually delete files

This change fixes an embarrassing blunder: the filename
we gave to os.Rename was absolutized twice (goplsDir+goplsDir+path),
so of course it was not found. The error was rightly ignored,
but this meant the bug was undetected. CI builder machines
filled their disks.

Also, this change causes filecache's GC to delete files older than
maxAge as soon as it encounters them, instead of in the second pass
over the sorted list of all files in the cache. This should
allow short-lived processes (e.g. tests) to make progress on
garbage collection. Though this now seems like a distinctly
third-order effect compared to... not deleting files at all.

Also:
- don't delay between stats after deleting files based on age.
- reduce the statDelay to 100us (was 1ms). Scanning a file tree
  on macOS is already very slow, at least on my Google-issued
  machine.
- reduce maxAge to 5 days (was 7), which should still tide most
  users over a long weekend.

Fixes golang/go#57900

Change-Id: I053f2891d6c52c94f4d5dd18903280dff2282eab
Reviewed-on: https://go-review.googlesource.com/c/tools/+/462597
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
Run-TryBot: Alan Donovan <adonovan@google.com>