Google Git
Sign in
go / tools / 51abc5bd865f4a8a94772f911be1a286a32202c3
commit51abc5bd865f4a8a94772f911be1a286a32202c3[log] [tgz]
authorAlan Donovan <adonovan@google.com>Fri Jan 20 23:17:55 2023 -0500
committerAlan Donovan <adonovan@google.com>Mon Jan 23 17:42:41 2023 +0000
treebebb800c6eaac6e8afaf650d2c27bf05af4ba1f4
parentce28f407b85d67101e4c6f783977f921c6f13788 [diff]
gopls/internal/lsp/source: stub: don't panic when encountering 'error'

The built-in error interface is the only non-trivial named interface
type with no package. This caused v0.11.0 of gopls to panic when
the ApplyFix stub operation was applied to an interface that embedded
'error'.  The crash was inadvertently fixed by recent changes, but still
the operation failed with an error that mentioned the filename "".
This change causes the operation to succeed with the proper result.

It also adds a test.

I think there's a simpler implementation of this operation following
the approach described in the existing comment that would obviate
the special-case logic added in this change.

Fixes golang/vscode-go#2606

Change-Id: I544de5f828055e999344117e4f8b2579bde21cfb
Reviewed-on: https://go-review.googlesource.com/c/tools/+/463035
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
Run-TryBot: Alan Donovan <adonovan@google.com>
5 files changed
tree: bebb800c6eaac6e8afaf650d2c27bf05af4ba1f4
  1. benchmark/
  2. blog/
  3. cmd/
  4. container/
  5. copyright/
  6. cover/
  7. go/
  8. godoc/
  9. gopls/
  10. imports/
  11. internal/
  12. playground/
  13. present/
  14. refactor/
  15. txtar/
  16. .gitattributes
  17. .gitignore
  18. .prettierrc
  19. codereview.cfg
  20. CONTRIBUTING.md
  21. go.mod
  22. go.sum
  23. LICENSE
  24. PATENTS
  25. README.md
README.md

Go Tools

PkgGoDev

This repository provides the golang.org/x/tools module, comprising various tools and packages mostly for static analysis of Go programs, some of which are listed below. Use the “Go reference” link above for more information about any package.

It also contains the golang.org/x/tools/gopls module, whose root package is a language-server protocol (LSP) server for Go. An LSP server analyses the source code of a project and responds to requests from a wide range of editors such as VSCode and Vim, allowing them to support IDE-like functionality.

Selected commands:

  • cmd/goimports formats a Go program like go fmt and additionally inserts import statements for any packages required by the file after it is edited.
  • cmd/callgraph prints the call graph of a Go program.
  • cmd/digraph is a utility for manipulating directed graphs in textual notation.
  • cmd/stringer generates declarations (including a String method) for “enum” types.
  • cmd/toolstash is a utility to simplify working with multiple versions of the Go toolchain.

These commands may be fetched with a command such as

go install golang.org/x/tools/cmd/goimports@latest

Selected packages:

  • go/ssa provides a static single-assignment form (SSA) intermediate representation (IR) for Go programs, similar to a typical compiler, for use by analysis tools.

  • go/packages provides a simple interface for loading, parsing, and type checking a complete Go program from source code.

  • go/analysis provides a framework for modular static analysis of Go programs.

  • go/callgraph provides call graphs of Go programs using a variety of algorithms with different trade-offs.

  • go/ast/inspector provides an optimized means of traversing a Go parse tree for use in analysis tools.

  • go/cfg provides a simple control-flow graph (CFG) for a Go function.

  • go/expect reads Go source files used as test inputs and interprets special comments within them as queries or assertions for testing.

  • go/gcexportdata and go/gccgoexportdata read and write the binary files containing type information used by the standard and gccgo compilers.

  • go/types/objectpath provides a stable naming scheme for named entities (“objects”) in the go/types API.

Numerous other packages provide more esoteric functionality.

Contributing

This repository uses Gerrit for code changes. To learn how to submit changes, see https://golang.org/doc/contribute.html.

The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.

JavaScript and CSS Formatting

This repository uses prettier to format JS and CSS files.

The version of prettier used is 1.18.2.

It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.