tree bebb800c6eaac6e8afaf650d2c27bf05af4ba1f4
parent ce28f407b85d67101e4c6f783977f921c6f13788
author Alan Donovan <adonovan@google.com> 1674274675 -0500
committer Alan Donovan <adonovan@google.com> 1674495761 +0000

gopls/internal/lsp/source: stub: don't panic when encountering 'error'

The built-in error interface is the only non-trivial named interface
type with no package. This caused v0.11.0 of gopls to panic when
the ApplyFix stub operation was applied to an interface that embedded
'error'.  The crash was inadvertently fixed by recent changes, but still
the operation failed with an error that mentioned the filename "".
This change causes the operation to succeed with the proper result.

It also adds a test.

I think there's a simpler implementation of this operation following
the approach described in the existing comment that would obviate
the special-case logic added in this change.

Fixes golang/vscode-go#2606

Change-Id: I544de5f828055e999344117e4f8b2579bde21cfb
Reviewed-on: https://go-review.googlesource.com/c/tools/+/463035
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
Run-TryBot: Alan Donovan <adonovan@google.com>