| commit | 4f7cb802ba5deae2bd4738c740f36760f11823ad | [log] [tgz] |
|---|---|---|
| author | Alan Donovan <adonovan@google.com> | Wed Nov 14 10:25:09 2018 -0500 |
| committer | Alan Donovan <adonovan@google.com> | Wed Nov 14 16:30:01 2018 +0000 |
| tree | cecfaf15b3d8268822a0ba7e383d7c3f115d8695 | |
| parent | 99072bc9d7ade6fc470d6c040de25d2edeac78c4 [diff] |
go/analysis/passes/asmdecl: turn two diagnostics into log messages Vet issues a warning (non-error diagnostic) when, for example, it cannot check an assembly file because the Go and asm symbols are in different packages. The new analysis API has no concept of warnings: any diagnostic always causes a non-zero exit. This change turns the asmdecl diagnostics back into warnings using log.Print, which is not ideal, but is necessary to pacify cmd/vet/all and its whitelist during the transition. Better solutions would be for the new analysis API to have a concept of warning, or for asmdecl to be silent and cmd/vet/all's whitelist not to expect these messages. Also, fix a bug in the "cross-check" predicate: cmd/vet confuses the name of a package and its path. The a∕b∕c names (using Unicode division slash) that appear in assembly correspond directly to the path. The only effective test of this change will be cmd/vet/all itself. Change-Id: I2e402d48717df723e2efdc2379636ec9b204031d Reviewed-on: https://go-review.googlesource.com/c/149598 Reviewed-by: Daniel Martí <mvdan@mvdan.cc> Reviewed-by: Michael Matloob <matloob@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.