| commit | 4d1d9acccfd63e494cda58054baf5113972ffacb | [log] [tgz] |
|---|---|---|
| author | Heschi Kreinick <heschi@google.com> | Tue Jul 21 14:17:53 2020 -0400 |
| committer | Heschi Kreinick <heschi@google.com> | Tue Jul 28 17:34:57 2020 +0000 |
| tree | fb18125ab442c2d51736d393faceb8dfeb9a7e22 | |
| parent | 72051f796149b570577cd7e666ea968b19e0745d [diff] |
internal/lsp/cache: fix parseKey The FileIdentity struct mixes information about the file itself (filename, hash) with information about the LSP references to that file (session ID, version). When we create a cache key using it, we only want the former, as returned by the String method. Otherwise we split the cache whenever those irrelevant fields are different. We also use FileIdentity as an element of diagnosticsKey, but I believe that use is appropriate. Change-Id: I094e00d2700e05778da635effbb69d0ebcb6726e Reviewed-on: https://go-review.googlesource.com/c/tools/+/244020 Reviewed-by: Robert Findley <rfindley@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.