tree fb18125ab442c2d51736d393faceb8dfeb9a7e22
parent 72051f796149b570577cd7e666ea968b19e0745d
author Heschi Kreinick <heschi@google.com> 1595355473 -0400
committer Heschi Kreinick <heschi@google.com> 1595957697 +0000

internal/lsp/cache: fix parseKey

The FileIdentity struct mixes information about the file itself
(filename, hash) with information about the LSP references to that file
(session ID, version). When we create a cache key using it, we only want
the former, as returned by the String method. Otherwise we split the
cache whenever those irrelevant fields are different.

We also use FileIdentity as an element of diagnosticsKey, but I believe
that use is appropriate.

Change-Id: I094e00d2700e05778da635effbb69d0ebcb6726e
Reviewed-on: https://go-review.googlesource.com/c/tools/+/244020
Reviewed-by: Robert Findley <rfindley@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>