| commit | 917f61dfb7ddaf4154035d0e21f74d4ab6982007 | [log] [tgz] |
|---|---|---|
| author | Rob Findley <rfindley@google.com> | Wed Jan 20 12:27:51 2021 -0500 |
| committer | Robert Findley <rfindley@google.com> | Mon Jan 25 18:11:24 2021 +0000 |
| tree | daa7a013eac3842177aa7860332a9fe5d8e2fafb | |
| parent | 2972602ec4f03242ffbc7f6ab020721687ed5fbe [diff] |
gopls/internal/regtest: automate counting of editor notifications to await Using awaiting a certain number of work items in the regtest is a source of flakes and latent bugs. This CL replaces all such assertions with assertions based on the number of notifications sent by the fake.Editor. While implementing this, I discovered several tests that had incorrect counting, so this may fix some flakes. Implementing this required pushing the asynchronous processing of file events into the Editor, rather than the Workdir. Change-Id: I9c3639409f2beed4a76295cbd53180c6e2ace126 Reviewed-on: https://go-review.googlesource.com/c/tools/+/285612 Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Trust: Robert Findley <rfindley@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.