tree daa7a013eac3842177aa7860332a9fe5d8e2fafb
parent 2972602ec4f03242ffbc7f6ab020721687ed5fbe
author Rob Findley <rfindley@google.com> 1611163671 -0500
committer Robert Findley <rfindley@google.com> 1611598284 +0000

gopls/internal/regtest: automate counting of editor notifications to await

Using awaiting a certain number of work items in the regtest is a source
of flakes and latent bugs. This CL replaces all such assertions with
assertions based on the number of notifications sent by the fake.Editor.

While implementing this, I discovered several tests that had incorrect
counting, so this may fix some flakes.

Implementing this required pushing the asynchronous processing of file
events into the Editor, rather than the Workdir.

Change-Id: I9c3639409f2beed4a76295cbd53180c6e2ace126
Reviewed-on: https://go-review.googlesource.com/c/tools/+/285612
Run-TryBot: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Robert Findley <rfindley@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>