| commit | 47ea21585cd7cbaa6078713a14b5f9a116791382 | [log] [tgz] |
|---|---|---|
| author | Muir Manders <muir@mnd.rs> | Wed Jun 26 23:28:06 2019 +0000 |
| committer | Rebecca Stambler <rstambler@golang.org> | Wed Jun 26 23:41:52 2019 +0000 |
| tree | a2548ffb9afab8b1b8b477650ca7acaa946096a2 | |
| parent | 5d636af2a98b10dea0bedabe1fa2b92cecb0fbfa [diff] |
internal/lsp: propagate context.Canceled when type checking typeCheck() was swallowing context.Canceled errors and leaving the cached package in a bad state. In particular, after two rapid changes to imports I was left in the "no package for file" error mode until I change my imports again. The second change canceled the first change which ended up sticking a skeleton *pkg in the package cache instead of propagating the canceled error. Change-Id: I15b072188c3359d9cd1812bd49e72548ba214250 GitHub-Last-Rev: 240f61718fbb5bfc787bbfaaaae1d38925d7c405 GitHub-Pull-Request: golang/tools#126 Reviewed-on: https://go-review.googlesource.com/c/tools/+/183940 Reviewed-by: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.