tree a2548ffb9afab8b1b8b477650ca7acaa946096a2
parent 5d636af2a98b10dea0bedabe1fa2b92cecb0fbfa
author Muir Manders <muir@mnd.rs> 1561591686 +0000
committer Rebecca Stambler <rstambler@golang.org> 1561592512 +0000

internal/lsp: propagate context.Canceled when type checking

typeCheck() was swallowing context.Canceled errors and leaving the
cached package in a bad state. In particular, after two rapid changes
to imports I was left in the "no package for file" error mode until I
change my imports again. The second change canceled the first change
which ended up sticking a skeleton *pkg in the package cache instead
of propagating the canceled error.

Change-Id: I15b072188c3359d9cd1812bd49e72548ba214250
GitHub-Last-Rev: 240f61718fbb5bfc787bbfaaaae1d38925d7c405
GitHub-Pull-Request: golang/tools#126
Reviewed-on: https://go-review.googlesource.com/c/tools/+/183940
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>