| commit | 434f7a8fef20980f5030380dbfe8388b63ff7c7a | [log] [tgz] |
|---|---|---|
| author | Ian Cottrell <iancottrell@google.com> | Sun Apr 12 22:47:10 2020 -0400 |
| committer | Ian Cottrell <iancottrell@google.com> | Mon Apr 20 21:05:32 2020 +0000 |
| tree | 36bf3b8ebf3a7172aca2508ddf8ff4bb559bcfbf | |
| parent | 98173f2f69e9b4c1a6e425907c79632cd44548a5 [diff] |
internal/jsonrpc2: add concrete types for Call, Notify and Response The previous implementation was exposing the details of the wire format and resulted in non idomatic go, detecting the presence of absence of values in fields to deterimine the message type. Now the messages are distinct types and we use type switches instead. Request still exists as an interface to expose the shared behaviour of Call and Notification, as this is the type accepted by handlers. The set of messages is deliberately closed by using a private methods on the interfaces. Change-Id: I2cf15ee3923ef4688670c62896f81f760c77fe04 Reviewed-on: https://go-review.googlesource.com/c/tools/+/228719 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.