tree 36bf3b8ebf3a7172aca2508ddf8ff4bb559bcfbf
parent 98173f2f69e9b4c1a6e425907c79632cd44548a5
author Ian Cottrell <iancottrell@google.com> 1586746030 -0400
committer Ian Cottrell <iancottrell@google.com> 1587416732 +0000

internal/jsonrpc2: add concrete types for Call, Notify and Response

The previous implementation was exposing the details of the wire format
and resulted in non idomatic go, detecting the presence of absence of
values in fields to deterimine the message type.
Now the messages are distinct types and we use type switches instead.
Request still exists as an interface to expose the shared behaviour of
Call and Notification, as this is the type accepted by handlers.
The set of messages is deliberately closed by using a private methods on the
interfaces.

Change-Id: I2cf15ee3923ef4688670c62896f81f760c77fe04
Reviewed-on: https://go-review.googlesource.com/c/tools/+/228719
Run-TryBot: Ian Cottrell <iancottrell@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>