| commit | 3f7c32638c09af103a99661c2dba5837243fc88b | [log] [tgz] |
|---|---|---|
| author | Rob Findley <rfindley@google.com> | Tue Jun 15 18:04:27 2021 -0400 |
| committer | Rebecca Stambler <rstambler@golang.org> | Wed Jun 16 00:40:27 2021 +0000 |
| tree | 0df072ca73337afba9e67146ac63ea67ee0be583 | |
| parent | b12e6172dcbceeb9b1b898035a3299c248210c8c [diff] |
gopls/internal/regtest: skip the flaky TestResolveImportCycle Also improve the description of the failing expectations. Updates golang/go#46773 Change-Id: I9465de8a5005bb7ee719a536f8550afc54bd6044 Reviewed-on: https://go-review.googlesource.com/c/tools/+/328369 Trust: Robert Findley <rfindley@google.com> Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
diff --git a/gopls/internal/regtest/diagnostics/diagnostics_test.go b/gopls/internal/regtest/diagnostics/diagnostics_test.go index 689ecad..9495201 100644 --- a/gopls/internal/regtest/diagnostics/diagnostics_test.go +++ b/gopls/internal/regtest/diagnostics/diagnostics_test.go
@@ -1618,6 +1618,7 @@ // Tests golang/go#46667: deleting a problematic import path should resolve // import cycle errors. func TestResolveImportCycle(t *testing.T) { + t.Skip("flaky test: see golang/go#46773") const mod = ` -- go.mod -- module mod.test
diff --git a/internal/lsp/regtest/expectation.go b/internal/lsp/regtest/expectation.go index bd7649d..408bf81 100644 --- a/internal/lsp/regtest/expectation.go +++ b/internal/lsp/regtest/expectation.go
@@ -525,7 +525,7 @@ } return SimpleExpectation{ check: check, - description: "empty diagnostics", + description: fmt.Sprintf("empty diagnostics for %q", name), } }