| commit | 3e93b52866ede40964c3167d35a3e1af4922d9c5 | [log] [tgz] |
|---|---|---|
| author | Muir Manders <muir@mnd.rs> | Tue Apr 23 22:34:23 2019 +0000 |
| committer | Rebecca Stambler <rstambler@golang.org> | Wed Apr 24 20:52:08 2019 +0000 |
| tree | 673d14fd367bf83e40d9643eadb93d4ba7bd3400 | |
| parent | cb2dda6eabdf9160e66ca7293897f984154a7f8b [diff] |
internal/lsp: suppress more completions in comments and literals Completion suppression in comments wasn't working for comments in switch case statements, select case statements, and decl statements. Rather than adding those to the list of leaf ast.Node types to look for, we now always check if the position is in a comment. This fix broke some completion tests that were using re"$" since "$" matches after the comment "//" characters. We now also don't complete within any literal values. Previously we only excluded string literals. Change-Id: If02f39f79fe2cd7417e39dbac2c6f84a484391ec GitHub-Last-Rev: 7ab3f526b6752a8f74413dcd268382d359e1beba GitHub-Pull-Request: golang/tools#88 Reviewed-on: https://go-review.googlesource.com/c/tools/+/173518 Reviewed-by: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.