tree 673d14fd367bf83e40d9643eadb93d4ba7bd3400
parent cb2dda6eabdf9160e66ca7293897f984154a7f8b
author Muir Manders <muir@mnd.rs> 1556058863 +0000
committer Rebecca Stambler <rstambler@golang.org> 1556139128 +0000

internal/lsp: suppress more completions in comments and literals

Completion suppression in comments wasn't working for comments in
switch case statements, select case statements, and decl statements.
Rather than adding those to the list of leaf ast.Node types to look
for, we now always check if the position is in a comment. This fix
broke some completion tests that were using re"$" since "$" matches
after the comment "//" characters.

We now also don't complete within any literal values. Previously we
only excluded string literals.

Change-Id: If02f39f79fe2cd7417e39dbac2c6f84a484391ec
GitHub-Last-Rev: 7ab3f526b6752a8f74413dcd268382d359e1beba
GitHub-Pull-Request: golang/tools#88
Reviewed-on: https://go-review.googlesource.com/c/tools/+/173518
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>