| commit | 181573a1c60823cfc68eb6582585106cc54f0e7e | [log] [tgz] |
|---|---|---|
| author | Heschi Kreinick <heschi@google.com> | Tue Nov 05 14:53:55 2019 -0500 |
| committer | Rebecca Stambler <rstambler@golang.org> | Wed Nov 06 19:45:32 2019 +0000 |
| tree | 3fb0b7d49e3b01939f67f59e72973d16dba68019 | |
| parent | 9b6bad85371f71fa5c77d78076253bdde8dfd521 [diff] |
internal/lsp/source: attach Package to completions when available Unimported completions now try to pull Packages from everywhere, not just the transitive dependencies of the current package. That confused the import formatting code, which only looked at deps. Pass the Package along with the import suggestion, and use it when it's present. Also change some error messages to be different for diagnostic purposes. Fixes golang/go#35359. Change-Id: Ia8ca923e46723e855ddd2da7611e6eb13c02bb4f Reviewed-on: https://go-review.googlesource.com/c/tools/+/205501 Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org> (cherry picked from commit 818555187f961fc0f6b11cdb7163349e41ba75f5) Reviewed-on: https://go-review.googlesource.com/c/tools/+/205658 Run-TryBot: Rebecca Stambler <rstambler@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.