tree 3fb0b7d49e3b01939f67f59e72973d16dba68019
parent 9b6bad85371f71fa5c77d78076253bdde8dfd521
author Heschi Kreinick <heschi@google.com> 1572983635 -0500
committer Rebecca Stambler <rstambler@golang.org> 1573069532 +0000

internal/lsp/source: attach Package to completions when available

Unimported completions now try to pull Packages from everywhere, not
just the transitive dependencies of the current package. That confused
the import formatting code, which only looked at deps. Pass the Package
along with the import suggestion, and use it when it's present.

Also change some error messages to be different for diagnostic purposes.

Fixes golang/go#35359.

Change-Id: Ia8ca923e46723e855ddd2da7611e6eb13c02bb4f
Reviewed-on: https://go-review.googlesource.com/c/tools/+/205501
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
(cherry picked from commit 818555187f961fc0f6b11cdb7163349e41ba75f5)
Reviewed-on: https://go-review.googlesource.com/c/tools/+/205658
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>