commit 36b1a880d5d1df625063b05d248a3ae77e083487
author Heschi Kreinick <heschi@google.com> Wed Sep 02 00:17:23 2020 -0400
committer Heschi Kreinick <heschi@google.com> Wed Sep 02 17:11:20 2020 +0000
tree d88f69c1d7e8801dccd7ef303300814dae57a777
parent 5d67d6c6f5c83887a8043ca3fc2474bf2572681b

internal/lsp/cache: use the right snapshot in ModUpgrade

Cache computations need to use the passed in snapshot.

Fixes golang/go#41056.

Change-Id: I09501f3fc6abccedcf33482c9ee4d58146fbe716
Reviewed-on: https://go-review.googlesource.com/c/tools/+/252437
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>

internal/lsp/cache/mod.go

diff --git a/internal/lsp/cache/mod.go b/internal/lsp/cache/mod.go
index c2e80ff..e62d7fd 100644
--- a/internal/lsp/cache/mod.go
+++ b/internal/lsp/cache/mod.go
@@ -306,7 +306,7 @@
 
 		snapshot := arg.(*snapshot)
 
-		pm, err := s.ParseMod(ctx, fh)
+		pm, err := snapshot.ParseMod(ctx, fh)
 		if err != nil {
 			return &modUpgradeData{err: err}
 		}