commit 2dc7ebab284bdfe6bb7ae8b77c3cccb0049e13ce
author Daniel Martí <mvdan@mvdan.cc> Mon Aug 07 12:04:59 2023 +0200
committer Robert Findley <rfindley@google.com> Mon Aug 07 12:58:43 2023 +0000
tree cd06c3041a3cf04a6e32564d0739ad3f2ef1452d
parent f91c023a9b093f57e379f719591d5e3725e07600

go/analysis: use parser.SkipObjectResolution

Neither of these two analysis passes relies on the now-deprecated
object tracking in go/ast populated by go/parser.

Change-Id: I8ec18d1552aedf437b2b663a2698010a6faee7c9
Reviewed-on: https://go-review.googlesource.com/c/tools/+/516575
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>

go/analysis/passes/buildtag/buildtag.go

diff --git a/go/analysis/passes/buildtag/buildtag.go b/go/analysis/passes/buildtag/buildtag.go
index a2a4a89..55bdad7 100644
--- a/go/analysis/passes/buildtag/buildtag.go
+++ b/go/analysis/passes/buildtag/buildtag.go
@@ -40,7 +40,7 @@
 	}
 	for _, name := range pass.IgnoredFiles {
 		if strings.HasSuffix(name, ".go") {
-			f, err := parser.ParseFile(pass.Fset, name, nil, parser.ParseComments)
+			f, err := parser.ParseFile(pass.Fset, name, nil, parser.ParseComments|parser.SkipObjectResolution)
 			if err != nil {
 				// Not valid Go source code - not our job to diagnose, so ignore.
 				return nil, nil

go/analysis/passes/cgocall/cgocall.go

diff --git a/go/analysis/passes/cgocall/cgocall.go b/go/analysis/passes/cgocall/cgocall.go
index c18b84b..98d9a77 100644
--- a/go/analysis/passes/cgocall/cgocall.go
+++ b/go/analysis/passes/cgocall/cgocall.go
@@ -180,7 +180,7 @@
 		// If f is a cgo-generated file, Position reports
 		// the original file, honoring //line directives.
 		filename := fset.Position(raw.Pos()).Filename
-		f, err := parser.ParseFile(fset, filename, nil, parser.Mode(0))
+		f, err := parser.ParseFile(fset, filename, nil, parser.SkipObjectResolution)
 		if err != nil {
 			return nil, nil, fmt.Errorf("can't parse raw cgo file: %v", err)
 		}