commit | 23e6869392724eca39d1cd2e784515cb69ac1bc6 | [log] [tgz] |
---|---|---|
author | Muir Manders <muir@mnd.rs> | Sun Aug 02 11:54:56 2020 -0700 |
committer | Rebecca Stambler <rstambler@golang.org> | Thu Aug 06 23:41:14 2020 +0000 |
tree | 08e20ccd1314781e62e6b411fdbab31ea5c4cec2 | |
parent | 41a9f6dc66344f2269f65b0206bdd9e069e437af [diff] |
internal/lsp/source: don't prefer bool candidates in bool exprs Consider this example: var foo, bar int if foo == 123 && b<> { } Completing at "<>" previously preferred the unimported "bytes.Contains()" function because it returns a bool. You often need to compose a boolean expression from non-boolean candidates, so preferring only bool candidates gives unhelpful results. Now we don't infer any expected type for "&&" and "||", which allows the example to prefer "bar" as the top candidate. Fixes golang/go#37163. Change-Id: Ic341da11dd626439cfb265d129288c5ca6008270 Reviewed-on: https://go-review.googlesource.com/c/tools/+/246362 Run-TryBot: Muir Manders <muir@mnd.rs> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.