tree 08e20ccd1314781e62e6b411fdbab31ea5c4cec2
parent 41a9f6dc66344f2269f65b0206bdd9e069e437af
author Muir Manders <muir@mnd.rs> 1596394496 -0700
committer Rebecca Stambler <rstambler@golang.org> 1596757274 +0000

internal/lsp/source: don't prefer bool candidates in bool exprs

Consider this example:

    var foo, bar int
    if foo == 123 && b<> {
    }

Completing at "<>" previously preferred the unimported
"bytes.Contains()" function because it returns a bool. You often need
to compose a boolean expression from non-boolean candidates, so
preferring only bool candidates gives unhelpful results. Now we don't
infer any expected type for "&&" and "||", which allows the example to
prefer "bar" as the top candidate.

Fixes golang/go#37163.

Change-Id: Ic341da11dd626439cfb265d129288c5ca6008270
Reviewed-on: https://go-review.googlesource.com/c/tools/+/246362
Run-TryBot: Muir Manders <muir@mnd.rs>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>