commit 2382e3994d48b1d22acc2c86bcad0a2aff028e32
author Dmitri Shuralyov <shurcooL@gmail.com> Thu Apr 27 19:18:25 2017 -0400
committer Brad Fitzpatrick <bradfitz@golang.org> Fri Apr 28 05:47:26 2017 +0000
tree 3dff7f3d588814c3c936e555d7488492f38bc73e
parent b6d1a163df3764ae6741562027e99e264f80cee9

go/vcs: allow go get on github.com/ import paths with Unicode letters

Manually apply same change as CL 41822 did for cmd/go/internal/get,
but for golang.org/x/tools/go/vcs, to help keep them in sync.

Updates golang/go#18660.
Helps golang/go#11490.

Change-Id: I6c7759c073583dea771bc438b70f8c2eb7b5ebfb
Reviewed-on: https://go-review.googlesource.com/42017
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

go/vcs/vcs.go

diff --git a/go/vcs/vcs.go b/go/vcs/vcs.go
index 7a11391..3c56a95 100644
--- a/go/vcs/vcs.go
+++ b/go/vcs/vcs.go
@@ -602,7 +602,7 @@
 	// Github
 	{
 		prefix: "github.com/",
-		re:     `^(?P<root>github\.com/[A-Za-z0-9_.\-]+/[A-Za-z0-9_.\-]+)(/[A-Za-z0-9_.\-]+)*$`,
+		re:     `^(?P<root>github\.com/[A-Za-z0-9_.\-]+/[A-Za-z0-9_.\-]+)(/[\p{L}0-9_.\-]+)*$`,
 		vcs:    "git",
 		repo:   "https://{root}",
 		check:  noVCSSuffix,

go/vcs/vcs_test.go

diff --git a/go/vcs/vcs_test.go b/go/vcs/vcs_test.go
index 5817ded..8f36cac 100644
--- a/go/vcs/vcs_test.go
+++ b/go/vcs/vcs_test.go
@@ -33,17 +33,25 @@
 				Repo: "https://github.com/golang/groupcache",
 			},
 		},
+		// Unicode letters in directories (issue 18660).
+		{
+			"github.com/user/unicode/испытание",
+			&RepoRoot{
+				VCS:  vcsGit,
+				Repo: "https://github.com/user/unicode",
+			},
+		},
 	}
 
 	for _, test := range tests {
 		got, err := RepoRootForImportPath(test.path, false)
 		if err != nil {
-			t.Errorf("RepoRootForImport(%q): %v", test.path, err)
+			t.Errorf("RepoRootForImportPath(%q): %v", test.path, err)
 			continue
 		}
 		want := test.want
 		if got.VCS.Name != want.VCS.Name || got.Repo != want.Repo {
-			t.Errorf("RepoRootForImport(%q) = VCS(%s) Repo(%s), want VCS(%s) Repo(%s)", test.path, got.VCS, got.Repo, want.VCS, want.Repo)
+			t.Errorf("RepoRootForImportPath(%q) = VCS(%s) Repo(%s), want VCS(%s) Repo(%s)", test.path, got.VCS, got.Repo, want.VCS, want.Repo)
 		}
 	}
 }