gopls/internal/lsp: enable clear builtin completion test
For golang/go#56351
Change-Id: I3a6e3ef58285d46fe239e900d98fdb5617a1733c
Reviewed-on: https://go-review.googlesource.com/c/tools/+/464240
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
diff --git a/gopls/internal/lsp/completion_test.go b/gopls/internal/lsp/completion_test.go
index d9a3e0d..cd3bcec 100644
--- a/gopls/internal/lsp/completion_test.go
+++ b/gopls/internal/lsp/completion_test.go
@@ -25,8 +25,8 @@
opts.LiteralCompletions = strings.Contains(string(src.URI()), "literal")
opts.ExperimentalPostfixCompletions = strings.Contains(string(src.URI()), "postfix")
})
- got = filterSkipCompletionItems(tests.FilterBuiltins(src, got))
- want := filterSkipCompletionItems(expected(t, test, items))
+ got = tests.FilterBuiltins(src, got)
+ want := expected(t, test, items)
if diff := tests.DiffCompletionItems(want, got); diff != "" {
t.Errorf("mismatching completion items (-want +got):\n%s", diff)
}
@@ -174,16 +174,3 @@
}
return list.Items
}
-
-func filterSkipCompletionItems(items []protocol.CompletionItem) []protocol.CompletionItem {
- n := 0
- for _, item := range items {
- // TODO(cuonglm): remove once https://go-review.googlesource.com/c/go/+/462935 land.
- if item.Label == "clear" {
- continue
- }
- items[n] = item
- n++
- }
- return items[:n]
-}
