commit 066fd1390ee0526e4b0a2855752efb3ea41a6648
author Hana (Hyang-Ah) Kim <hyangah@gmail.com> Mon Apr 06 17:06:51 2020 -0400
committer Hyang-Ah Hana Kim <hyangah@gmail.com> Mon Apr 06 21:38:09 2020 +0000
tree c28882e9ecaa1207ae66f2478bfdbe355fc1663d
parent 1fd976651f4da6cc8c239c50463fb2d82641fa77

internal/telemetry/event: fix error/value key type tag formatting

%v behaves better with nil values.

Change-Id: I4041f5460173c8f420553996d64d9463ef5a0370
Reviewed-on: https://go-review.googlesource.com/c/tools/+/227355
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Robert Findley <rfindley@google.com>

internal/telemetry/event/tag.go

diff --git a/internal/telemetry/event/tag.go b/internal/telemetry/event/tag.go
index 7d7a34c..e3c81eb 100644
--- a/internal/telemetry/event/tag.go
+++ b/internal/telemetry/event/tag.go
@@ -106,9 +106,9 @@
 	case *StringKey:
 		fmt.Fprintf(f, "%s=%q", key.Name(), key.From(t))
 	case *ErrorKey:
-		fmt.Fprintf(f, "%s=%q", key.Name(), key.From(t))
+		fmt.Fprintf(f, "%s=%v", key.Name(), key.From(t))
 	case *ValueKey:
-		fmt.Fprintf(f, "%s=%q", key.Name(), key.From(t))
+		fmt.Fprintf(f, "%s=%v", key.Name(), key.From(t))
 	default:
 		fmt.Fprintf(f, `%s="invalid type %T"`, key.Name(), key)
 	}