Google Git
Sign in
go / telemetry / f2b69109f79bfe2c861f49a44f1691fd80d4b86c
commitf2b69109f79bfe2c861f49a44f1691fd80d4b86c[log] [tgz]
authorRob Findley <rfindley@google.com>Mon Jun 03 21:56:34 2024 +0000
committerGopher Robot <gobot@golang.org>Mon Jun 03 22:45:50 2024 +0000
tree0a5457d36a31c4abf3955b0b00528c6e5c27d921
parent469116581a8ea2aa4335b3f4ff3d78e18871fa2d [diff]
internal/counter: return an error when the weekends file is empty

This bug manifested in load testing: depending on the nature of races,
the weekends file can be empty. An apparent bug caused a nil error to be
returned in this case.

Also fix a mixuse of rotate instead of rotate1.

Change-Id: I69e8e767ee2a49449cd41f62e255659755935652
Reviewed-on: https://go-review.googlesource.com/c/telemetry/+/589937
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Auto-Submit: Robert Findley <rfindley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2 files changed
tree: 0a5457d36a31c4abf3955b0b00528c6e5c27d921
  1. cmd/
  2. config/
  3. counter/
  4. crashmonitor/
  5. godev/
  6. internal/
  7. .dockerignore
  8. .eslintrc.json
  9. .gitattributes
  10. .gitignore
  11. .prettierrc.json
  12. .stylelintrc.json
  13. CONTRIBUTING.md
  14. dir.go
  15. doc.go
  16. go.mod
  17. go.sum
  18. LICENSE
  19. mode.go
  20. npm
  21. npx
  22. package-lock.json
  23. package.json
  24. PATENTS
  25. README.md
  26. start.go
  27. start_posix.go
  28. start_test.go
  29. start_windows.go
  30. tsconfig.json
  31. types_alias.go
README.md

Go Telemetry

This repository holds the Go Telemetry server code and libraries, used for hosting telemetry.go.dev and instrumenting Go toolchain programs with opt-in telemetry.

Warning: this repository is intended for use only in tools maintained by the Go team, including tools in the Go distribution and auxiliary tools like gopls or govulncheck. There are no compatibility guarantees for any of the packages here: public APIs will change in breaking ways as the telemetry integration is refined.

Notable Packages

Contributing

This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.

The main issue tracker for the time repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/telemetry:” in the subject line, so it is easy to find.

Linting & Formatting

This repository uses eslint to format TS files, stylelint to format CSS files, and prettier to format TS, CSS, Markdown, and YAML files.

See the style guides:

It is encouraged that all TS and CSS code be run through formatters before submitting a change. However, it is not a strict requirement enforced by CI.

Installing npm Dependencies:

  1. Install docker
  2. Run ./npm install

Run ESLint, Stylelint, & Prettier

./npm run all