Google Git
Sign in
go / telemetry / 19675431963b3b91083959810dbde91edf452ff8
commit19675431963b3b91083959810dbde91edf452ff8[log] [tgz]
authorRob Findley <rfindley@google.com>Fri Sep 27 18:32:05 2024 +0000
committerGopher Robot <gobot@golang.org>Fri Sep 27 18:46:29 2024 +0000
tree8872b6dbe8d55b96db67d2081ae15e1acdbdfa42
parent1b7b43a8aaf29e66f494d5b816bc840ce24358fc [diff]
telemetry: fix automated crash reporting using telemetry.Start

Following CL 592017, the child process started by telemetry.Start no
longer opens the counter file, causing crash reports to be dropped on
the floor. Fix this, with a test.

Fixes golang/go#69681

Change-Id: I423533d5b1e2369f13880cecd9137cd7c9239240
Reviewed-on: https://go-review.googlesource.com/c/telemetry/+/616396
Reviewed-by: Alan Donovan <adonovan@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Robert Findley <rfindley@google.com>
2 files changed
tree: 8872b6dbe8d55b96db67d2081ae15e1acdbdfa42
  1. cmd/
  2. config/
  3. counter/
  4. crashmonitor/
  5. godev/
  6. internal/
  7. .dockerignore
  8. .eslintrc.json
  9. .gitattributes
  10. .gitignore
  11. .prettierrc.json
  12. .stylelintrc.json
  13. CONTRIBUTING.md
  14. dir.go
  15. doc.go
  16. go.mod
  17. go.sum
  18. LICENSE
  19. mode.go
  20. npm
  21. npx
  22. package-lock.json
  23. package.json
  24. PATENTS
  25. README.md
  26. start.go
  27. start_posix.go
  28. start_test.go
  29. start_windows.go
  30. tsconfig.json
  31. types_alias.go
README.md

Go Telemetry

This repository holds the Go Telemetry server code and libraries, used for hosting telemetry.go.dev and instrumenting Go toolchain programs with opt-in telemetry.

Warning: this repository is intended for use only in tools maintained by the Go team, including tools in the Go distribution and auxiliary tools like gopls or govulncheck. There are no compatibility guarantees for any of the packages here: public APIs will change in breaking ways as the telemetry integration is refined.

Notable Packages

Contributing

This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.

The main issue tracker for the telemetry repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/telemetry:” in the subject line, so it is easy to find.

Linting & Formatting

This repository uses eslint to format TS files, stylelint to format CSS files, and prettier to format TS, CSS, Markdown, and YAML files.

See the style guides:

It is encouraged that all TS and CSS code be run through formatters before submitting a change. However, it is not a strict requirement enforced by CI.

Installing npm Dependencies:

  1. Install docker
  2. Run ./npm install

Run ESLint, Stylelint, & Prettier

./npm run all