cmd/stacks: match predicates against individual configurations claimStacks currently concatenates all configurations associated with a stack before evaluating a predicate. As a result, different terms of a conjunction may match different configurations. For example, a stack observed on linux/amd64 and darwin/arm64 incorrectly matches a predicate requiring linux/arm64. Evaluate the predicate separately for each stack/configuration pair, and claim the stack if any individual configuration matches. Add coverage for cross-configuration combinations. Fixes golang/go#80660 Change-Id: Ie5200bab1d238dc85ef11c778eb682ce63b348e3 Reviewed-on: https://go-review.googlesource.com/c/telemetry/+/808383 Reviewed-by: race quite <quiterace@gmail.com> Reviewed-by: Hongxiang Jiang <hxjiang@golang.org> Reviewed-by: Alan Donovan <adonovan@google.com> Auto-Submit: Hongxiang Jiang <hxjiang@golang.org> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This repository holds the Go Telemetry server code and libraries, used for hosting telemetry.go.dev and instrumenting Go toolchain programs with opt-in telemetry.
Warning: this repository is intended for use only in tools maintained by the Go team, including tools in the Go distribution and auxiliary tools like gopls or govulncheck. There are no compatibility guarantees for any of the packages here: public APIs will change in breaking ways as the telemetry integration is refined.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://go.dev/doc/contribute.
The git repository is https://go.googlesource.com/telemetry.
The main issue tracker for the telemetry repository is located at https://go.dev/issues. Prefix your issue with “x/telemetry:” in the subject line, so it is easy to find.
This repository uses eslint to format TS files, stylelint to format CSS files, and prettier to format TS, CSS, Markdown, and YAML files.
See the style guides:
It is encouraged that all TS and CSS code be run through formatters before submitting a change. However, it is not a strict requirement enforced by CI.
./npm install./npm run all