Google Git
Sign in
go / telemetry / a797f331ea9751d12606eb814afec1ecabfa4ac3
commita797f331ea9751d12606eb814afec1ecabfa4ac3[log] [tgz]
authorRob Findley <rfindley@google.com>Wed Aug 28 19:16:13 2024 +0000
committerRobert Findley <rfindley@google.com>Wed Aug 28 20:22:01 2024 +0000
treeb7edaf97fc63f46178a8280017b49c110993c032
parent354bfb863b4d334e7bdab18f110ae3dcabab9fd3 [diff]
internal/upload: only download the upload config if the mode is "on"

This is a second, simpler approach to addressing golang/go#68946, after
CL 607796 was deemed too complicated (and contained a bug!).

Simply check the mode file before downloading the upload config. The
test from CL 607796 are preserved.

For golang/go#68946

Change-Id: I1f11252456df2471e1eafe34e72ca9e369ff8e6a
Reviewed-on: https://go-review.googlesource.com/c/telemetry/+/609275
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
3 files changed
tree: b7edaf97fc63f46178a8280017b49c110993c032
  1. cmd/
  2. config/
  3. counter/
  4. crashmonitor/
  5. godev/
  6. internal/
  7. .dockerignore
  8. .eslintrc.json
  9. .gitattributes
  10. .gitignore
  11. .prettierrc.json
  12. .stylelintrc.json
  13. CONTRIBUTING.md
  14. dir.go
  15. doc.go
  16. go.mod
  17. go.sum
  18. LICENSE
  19. mode.go
  20. npm
  21. npx
  22. package-lock.json
  23. package.json
  24. PATENTS
  25. README.md
  26. start.go
  27. start_posix.go
  28. start_test.go
  29. start_windows.go
  30. tsconfig.json
  31. types_alias.go
README.md

Go Telemetry

This repository holds the Go Telemetry server code and libraries, used for hosting telemetry.go.dev and instrumenting Go toolchain programs with opt-in telemetry.

Warning: this repository is intended for use only in tools maintained by the Go team, including tools in the Go distribution and auxiliary tools like gopls or govulncheck. There are no compatibility guarantees for any of the packages here: public APIs will change in breaking ways as the telemetry integration is refined.

Notable Packages

Contributing

This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.

The main issue tracker for the time repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/telemetry:” in the subject line, so it is easy to find.

Linting & Formatting

This repository uses eslint to format TS files, stylelint to format CSS files, and prettier to format TS, CSS, Markdown, and YAML files.

See the style guides:

It is encouraged that all TS and CSS code be run through formatters before submitting a change. However, it is not a strict requirement enforced by CI.

Installing npm Dependencies:

  1. Install docker
  2. Run ./npm install

Run ESLint, Stylelint, & Prettier

./npm run all