Google Git
Sign in
go / telemetry / 98772af85899
commit98772af8589950babe75ed35aab8cca6623a06d7[log] [tgz]
authorRob Findley <rfindley@google.com>Thu May 16 18:32:56 2024 +0000
committerRobert Findley <rfindley@google.com>Thu May 16 18:58:56 2024 +0000
tree0893bdcce0bd90e1bea0de51eb5b33efd0b45155
parent9ff3ad9b3e6802ed3bbc6ef4939986eabab5216b [diff]
start: when upload && !crashmonitor.Supported(), don't use crashmonitor

CL 585416 in x/tools changed gopls to call telemetry.Start with both
Upload and ReportCrashes, but a bug in the telemetry.Start logic
resulted in crashmonitor.Parent being called even when
!crashmonitor.Supported(), due to a standard disjoint condition error.

Fix this by consolidating all handling of telemetry.Config into
telemetry.Start, and passing in the derived predicates.

For golang/go#67430

Change-Id: I2cb4eeae0c98e295af6d531a94090a401f8d0103
Reviewed-on: https://go-review.googlesource.com/c/telemetry/+/586195
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
1 file changed
tree: 0893bdcce0bd90e1bea0de51eb5b33efd0b45155
  1. cmd/
  2. config/
  3. counter/
  4. crashmonitor/
  5. godev/
  6. internal/
  7. .dockerignore
  8. .eslintrc.json
  9. .gitattributes
  10. .gitignore
  11. .prettierrc.json
  12. .stylelintrc.json
  13. CONTRIBUTING.md
  14. dir.go
  15. doc.go
  16. go.mod
  17. go.sum
  18. LICENSE
  19. mode.go
  20. npm
  21. npx
  22. package-lock.json
  23. package.json
  24. PATENTS
  25. README.md
  26. start.go
  27. start_posix.go
  28. start_test.go
  29. start_windows.go
  30. tsconfig.json
  31. types_alias.go
README.md

Go Telemetry

This repository holds the Go Telemetry server code and libraries, used for hosting telemetry.go.dev and instrumenting Go toolchain programs with opt-in telemetry.

Warning: this repository is intended for use only in tools maintained by the Go team, including tools in the Go distribution and auxiliary tools like gopls or govulncheck. There are no compatibility guarantees for any of the packages here: public APIs will change in breaking ways as the telemetry integration is refined.

Notable Packages

Contributing

This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.

The main issue tracker for the time repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/telemetry:” in the subject line, so it is easy to find.

Linting & Formatting

This repository uses eslint to format TS files, stylelint to format CSS files, and prettier to format TS, CSS, Markdown, and YAML files.

See the style guides:

It is encouraged that all TS and CSS code be run through formatters before submitting a change. However, it is not a strict requirement enforced by CI.

Installing npm Dependencies:

  1. Install docker
  2. Run ./npm install

Run ESLint, Stylelint, & Prettier

./npm run all