Google Git
Sign in
go / telemetry / 865cc6769b63b9f8c4d1138da5edd25ad2f5b0f7
commit865cc6769b63b9f8c4d1138da5edd25ad2f5b0f7[log] [tgz]
authorRob Findley <rfindley@google.com>Thu Sep 12 20:26:08 2024 +0000
committerRobert Findley <rfindley@google.com>Fri Sep 13 16:31:07 2024 +0000
tree2d4cf5a81703b06bdfb069fa966a728a0ef7fa4d
parent22fe4a1e7b9ca9039a2025affc5c2548fac7fc36 [diff]
godev/cmd/worker: address several TODOs in data representation

Make several small simplifications to the worker:
- Remove the now unnecessary logic to store the number of reports in a
  special map key.
- Simplify the logic for skipping a chart: charts are skipped whenever
  there is no data (this was inconsistent for user defined charts and
  program info charts).
- Don't sum records with the same ID. We won't encounter these in
  practice because uploading overwrites.

Change-Id: I8a498c31f13e7e9751c40f3466cfb1a78dcd50bf
Reviewed-on: https://go-review.googlesource.com/c/telemetry/+/611846
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
4 files changed
tree: 2d4cf5a81703b06bdfb069fa966a728a0ef7fa4d
  1. cmd/
  2. config/
  3. counter/
  4. crashmonitor/
  5. godev/
  6. internal/
  7. .dockerignore
  8. .eslintrc.json
  9. .gitattributes
  10. .gitignore
  11. .prettierrc.json
  12. .stylelintrc.json
  13. CONTRIBUTING.md
  14. dir.go
  15. doc.go
  16. go.mod
  17. go.sum
  18. LICENSE
  19. mode.go
  20. npm
  21. npx
  22. package-lock.json
  23. package.json
  24. PATENTS
  25. README.md
  26. start.go
  27. start_posix.go
  28. start_test.go
  29. start_windows.go
  30. tsconfig.json
  31. types_alias.go
README.md

Go Telemetry

This repository holds the Go Telemetry server code and libraries, used for hosting telemetry.go.dev and instrumenting Go toolchain programs with opt-in telemetry.

Warning: this repository is intended for use only in tools maintained by the Go team, including tools in the Go distribution and auxiliary tools like gopls or govulncheck. There are no compatibility guarantees for any of the packages here: public APIs will change in breaking ways as the telemetry integration is refined.

Notable Packages

Contributing

This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.

The main issue tracker for the telemetry repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/telemetry:” in the subject line, so it is easy to find.

Linting & Formatting

This repository uses eslint to format TS files, stylelint to format CSS files, and prettier to format TS, CSS, Markdown, and YAML files.

See the style guides:

It is encouraged that all TS and CSS code be run through formatters before submitting a change. However, it is not a strict requirement enforced by CI.

Installing npm Dependencies:

  1. Install docker
  2. Run ./npm install

Run ESLint, Stylelint, & Prettier

./npm run all