Google Git
Sign in
go / telemetry / 74ed92f77bb49f52b9040e7bc597b530825a9380
commit74ed92f77bb49f52b9040e7bc597b530825a9380[log] [tgz]
authorRob Findley <rfindley@google.com>Wed Sep 11 14:48:18 2024 +0000
committerRobert Findley <rfindley@google.com>Wed Sep 11 17:47:54 2024 +0000
tree1ea27c681dc3a5265831841b9584802d7d464691
parent6d9f2eb83631e39f6d0b87dd8411b8f5d7fac38e [diff]
godev/cmd/worker: don't include buckets in the chart ID

Right now, when you click on a specific chart in the chart browser, it
updates the location to include the full counter line, including
buckets. The buckets are suppressed in the chart name only due to a
template func that trims them.

But buckets are not relevant to the identity of the chart, and result in
a very long URL. Trim the ID to only include the counter prefix.

Change-Id: Iddd1a932df4f44beb490e7225208d9c476ca7e56
Reviewed-on: https://go-review.googlesource.com/c/telemetry/+/611841
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Hongxiang Jiang <hxjiang@golang.org>
2 files changed
tree: 1ea27c681dc3a5265831841b9584802d7d464691
  1. cmd/
  2. config/
  3. counter/
  4. crashmonitor/
  5. godev/
  6. internal/
  7. .dockerignore
  8. .eslintrc.json
  9. .gitattributes
  10. .gitignore
  11. .prettierrc.json
  12. .stylelintrc.json
  13. CONTRIBUTING.md
  14. dir.go
  15. doc.go
  16. go.mod
  17. go.sum
  18. LICENSE
  19. mode.go
  20. npm
  21. npx
  22. package-lock.json
  23. package.json
  24. PATENTS
  25. README.md
  26. start.go
  27. start_posix.go
  28. start_test.go
  29. start_windows.go
  30. tsconfig.json
  31. types_alias.go
README.md

Go Telemetry

This repository holds the Go Telemetry server code and libraries, used for hosting telemetry.go.dev and instrumenting Go toolchain programs with opt-in telemetry.

Warning: this repository is intended for use only in tools maintained by the Go team, including tools in the Go distribution and auxiliary tools like gopls or govulncheck. There are no compatibility guarantees for any of the packages here: public APIs will change in breaking ways as the telemetry integration is refined.

Notable Packages

Contributing

This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.

The main issue tracker for the telemetry repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/telemetry:” in the subject line, so it is easy to find.

Linting & Formatting

This repository uses eslint to format TS files, stylelint to format CSS files, and prettier to format TS, CSS, Markdown, and YAML files.

See the style guides:

It is encouraged that all TS and CSS code be run through formatters before submitting a change. However, it is not a strict requirement enforced by CI.

Installing npm Dependencies:

  1. Install docker
  2. Run ./npm install

Run ESLint, Stylelint, & Prettier

./npm run all