| commit | 4b27ed8f8bbbd165d58658452da8fd15fa42ebea | [log] [tgz] |
|---|---|---|
| author | Robert Findley <rfindley@google.com> | Mon May 06 10:01:21 2024 -0400 |
| committer | Robert Findley <rfindley@google.com> | Tue May 07 14:28:59 2024 +0000 |
| tree | 47e78b04cc22f129cb21b9f6fa7c6a599f0b7194 | |
| parent | 0f8345c7cb0b06c0e0edff75a29d1f9201378e94 [diff] |
telemetry: add a test for Start
Add an end-to-end test for Start, which exacerbates the integration bug
described in golang/go#67211.
To achieve this, make the following API changes:
- Add telemetry.Config.{UploadStartTime, UploadURL}, to pass through to
the upload configuration.
- Add a StartResult return for Start, with a single Wait() method.
Also fix a bug that regtest.RunProg appeared to accidentally lose the
os.Environ when invoking its subprocess.
Updates golang/go#67211
Fixes golang/go#66003
Change-Id: Ic9e53742cd96991452a37601fb5454ef2bdc3d1a
Reviewed-on: https://go-review.googlesource.com/c/telemetry/+/583495
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
This repository holds the Go Telemetry server code and libraries, used for hosting telemetry.go.dev and instrumenting Go toolchain programs with opt-in telemetry.
Warning: this repository is intended for use only in tools maintained by the Go team, including tools in the Go distribution and auxiliary tools like gopls or govulncheck. There are no compatibility guarantees for any of the packages here: public APIs will change in breaking ways as the telemetry integration is refined.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the time repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/telemetry:” in the subject line, so it is easy to find.
This repository uses eslint to format TS files, stylelint to format CSS files, and prettier to format TS, CSS, Markdown, and YAML files.
See the style guides:
It is encouraged that all TS and CSS code be run through formatters before submitting a change. However, it is not a strict requirement enforced by CI.
./npm install./npm run all