| commit | fd5c27b581eaff33c65286a48dad6de481267a9b | [log] [tgz] |
|---|---|---|
| author | Rob Findley <rfindley@google.com> | Fri May 10 13:07:20 2024 +0000 |
| committer | Gopher Robot <gobot@golang.org> | Fri May 10 20:42:39 2024 +0000 |
| tree | 868081b9c64448a399ee0ad618f3bacb3483f6d5 | |
| parent | f0a2a9af59704e026232f9de34f9eb9a35f5a655 [diff] |
internal/counter: remove fall-back logic in Parse for missing TimeBegin Remove fallback logic in counter.Parse to handle a missing "TimeBegin" metadata field. All counters should have this field populated (it is written by file.init). To ensure we catch this form of corruption, return an error from counterDateSpan when the TimeBegin or TimeEnd fields are missing (this was a pre-existing TODO). The logic dates to the original instance of the counter package, so it is likely just obsolete. For golang/go#65970 Change-Id: I6a75a42f3092c3471fe95cda1958b57b954e9140 Reviewed-on: https://go-review.googlesource.com/c/telemetry/+/584402 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> Auto-Submit: Robert Findley <rfindley@google.com>
This repository holds the Go Telemetry server code and libraries, used for hosting telemetry.go.dev and instrumenting Go toolchain programs with opt-in telemetry.
Warning: this repository is intended for use only in tools maintained by the Go team, including tools in the Go distribution and auxiliary tools like gopls or govulncheck. There are no compatibility guarantees for any of the packages here: public APIs will change in breaking ways as the telemetry integration is refined.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the time repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/telemetry:” in the subject line, so it is easy to find.
This repository uses eslint to format TS files, stylelint to format CSS files, and prettier to format TS, CSS, Markdown, and YAML files.
See the style guides:
It is encouraged that all TS and CSS code be run through formatters before submitting a change. However, it is not a strict requirement enforced by CI.
./npm install./npm run all