commit efd3b9a0ff205c921c51961c1c9bb8728bd0ce1b
author Tobias Klauser <tklauser@distanz.ch> Wed Sep 16 11:36:22 2020 +0200
committer Tobias Klauser <tobias.klauser@gmail.com> Thu Sep 17 07:31:48 2020 +0000
tree 06f97f1dcd283794d5ddd42c4f8a298764e150ca
parent 648f2a039071f6a0cb589f30537d5f6279c6002b

unix: skip TestClonefile* on ENOSYS or ENOTSUP

The clonefile syscalls added by CL 254757 might fail on certain macOS
versions and/or file systems according to the clonefile(2) manpage. Skip
the corresponding tests in these cases.

This fixes the test failure on the darwin-amd64-10_12 builder.

Change-Id: Iae1d2b6d8e2fcddc129d639f003fbb1817b45006
Reviewed-on: https://go-review.googlesource.com/c/sys/+/255198
Trust: Tobias Klauser <tobias.klauser@gmail.com>
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>

unix/syscall_darwin_test.go

diff --git a/unix/syscall_darwin_test.go b/unix/syscall_darwin_test.go
index 149992c..e7f6bdd 100644
--- a/unix/syscall_darwin_test.go
+++ b/unix/syscall_darwin_test.go
@@ -57,7 +57,9 @@
 
 	clonedName := file.Name() + "-cloned"
 	err := unix.Clonefile(file.Name(), clonedName, 0)
-	if err != nil {
+	if err == unix.ENOSYS || err == unix.ENOTSUP {
+		t.Skip("clonefile is not available or supported, skipping test")
+	} else if err != nil {
 		t.Fatal(err)
 	}
 	defer os.Remove(clonedName)
@@ -78,10 +80,11 @@
 
 	clonedName := file.Name() + "-cloned"
 	err := unix.Clonefileat(unix.AT_FDCWD, file.Name(), unix.AT_FDCWD, clonedName, 0)
-	if err != nil {
+	if err == unix.ENOSYS || err == unix.ENOTSUP {
+		t.Skip("clonefileat is not available or supported, skipping test")
+	} else if err != nil {
 		t.Fatal(err)
 	}
-
 	defer os.Remove(clonedName)
 
 	clonedData, err := ioutil.ReadFile(clonedName)
@@ -134,7 +137,9 @@
 	src := path.Base(srcFile.Name())
 	dst := path.Base(dstFile.Name())
 	err = unix.Clonefileat(srcFd, src, dstFd, dst, 0)
-	if err != nil {
+	if err == unix.ENOSYS || err == unix.ENOTSUP {
+		t.Skip("clonefileat is not available or supported, skipping test")
+	} else if err != nil {
 		t.Fatal(err)
 	}
 
@@ -165,7 +170,9 @@
 	os.Remove(dstFile.Name())
 
 	err = unix.Fclonefileat(fd, unix.AT_FDCWD, dstFile.Name(), 0)
-	if err != nil {
+	if err == unix.ENOSYS || err == unix.ENOTSUP {
+		t.Skip("clonefileat is not available or supported, skipping test")
+	} else if err != nil {
 		t.Fatal(err)
 	}