commit 9f70ab9862d5f8a6a359cf0820d142e431318a8e
author Alex Brainman <alex.brainman@gmail.com> Sat Oct 24 17:55:14 2020 +1100
committer Alex Brainman <alex.brainman@gmail.com> Sat Oct 24 23:29:16 2020 +0000
tree ae7b61bc4f3428b161c2100cc3db8eec56bf28d9
parent ef9fd89ba245e184bdd308f7f2b4f3c551fa5b0f

windows/mkwinsyscall: use global variable to avoid allocation in errnoErr

Change-Id: I6f089ea96bfbad6390c50a63e9d2fb290cc8654a
Reviewed-on: https://go-review.googlesource.com/c/sys/+/264578
Trust: Alex Brainman <alex.brainman@gmail.com>
Run-TryBot: Alex Brainman <alex.brainman@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>

windows/mkwinsyscall/mkwinsyscall.go

diff --git a/windows/mkwinsyscall/mkwinsyscall.go b/windows/mkwinsyscall/mkwinsyscall.go
index ff8b39d..ed8c3ac 100644
--- a/windows/mkwinsyscall/mkwinsyscall.go
+++ b/windows/mkwinsyscall/mkwinsyscall.go
@@ -864,6 +864,7 @@
 
 var (
 	errERROR_IO_PENDING error = {{syscalldot}}Errno(errnoERROR_IO_PENDING)
+	errERROR_EINVAL error     = {{syscalldot}}EINVAL
 )
 
 // errnoErr returns common boxed Errno values, to prevent
@@ -871,7 +872,7 @@
 func errnoErr(e {{syscalldot}}Errno) error {
 	switch e {
 	case 0:
-		return {{syscalldot}}EINVAL
+		return errERROR_EINVAL
 	case errnoERROR_IO_PENDING:
 		return errERROR_IO_PENDING
 	}

windows/registry/zsyscall_windows.go

diff --git a/windows/registry/zsyscall_windows.go b/windows/registry/zsyscall_windows.go
index 5b02df2..fc1835d 100644
--- a/windows/registry/zsyscall_windows.go
+++ b/windows/registry/zsyscall_windows.go
@@ -19,6 +19,7 @@
 
 var (
 	errERROR_IO_PENDING error = syscall.Errno(errnoERROR_IO_PENDING)
+	errERROR_EINVAL     error = syscall.EINVAL
 )
 
 // errnoErr returns common boxed Errno values, to prevent
@@ -26,7 +27,7 @@
 func errnoErr(e syscall.Errno) error {
 	switch e {
 	case 0:
-		return syscall.EINVAL
+		return errERROR_EINVAL
 	case errnoERROR_IO_PENDING:
 		return errERROR_IO_PENDING
 	}

windows/zsyscall_windows.go

diff --git a/windows/zsyscall_windows.go b/windows/zsyscall_windows.go
index a25f096..f50d037 100644
--- a/windows/zsyscall_windows.go
+++ b/windows/zsyscall_windows.go
@@ -17,6 +17,7 @@
 
 var (
 	errERROR_IO_PENDING error = syscall.Errno(errnoERROR_IO_PENDING)
+	errERROR_EINVAL     error = syscall.EINVAL
 )
 
 // errnoErr returns common boxed Errno values, to prevent
@@ -24,7 +25,7 @@
 func errnoErr(e syscall.Errno) error {
 	switch e {
 	case 0:
-		return syscall.EINVAL
+		return errERROR_EINVAL
 	case errnoERROR_IO_PENDING:
 		return errERROR_IO_PENDING
 	}