commit 8ad439b19e0fb2ded35375e495090c1334011eb9
author Meng Zhuo <mzh@golangcn.org> Thu Dec 10 09:12:51 2020 +0800
committer Meng Zhuo <mzh@golangcn.org> Fri Dec 11 09:08:39 2020 +0000
tree 587068aa8013a54c4c9df1978026ce765a3e460d
parent 1f0c578a6b29fe7726db1540f375fd47f55fc1e8

windows: remove ErrorControl value check in CreateService

ErrorIgnore is 0 which means we shouldn't rely on zero value checking.

Fixes golang/go#43094

Change-Id: I7af3132cfe58d73c7abab92203fb02a0ada15218
Reviewed-on: https://go-review.googlesource.com/c/sys/+/276572
Trust: Meng Zhuo <mzh@golangcn.org>
Trust: Alex Brainman <alex.brainman@gmail.com>
Trust: Jason A. Donenfeld <Jason@zx2c4.com>
Run-TryBot: Meng Zhuo <mzh@golangcn.org>
Run-TryBot: Jason A. Donenfeld <Jason@zx2c4.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jason A. Donenfeld <Jason@zx2c4.com>
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>

windows/svc/mgr/mgr.go

diff --git a/windows/svc/mgr/mgr.go b/windows/svc/mgr/mgr.go
index 9a454da..8e78daf 100644
--- a/windows/svc/mgr/mgr.go
+++ b/windows/svc/mgr/mgr.go
@@ -117,9 +117,6 @@
 	if c.StartType == 0 {
 		c.StartType = StartManual
 	}
-	if c.ErrorControl == 0 {
-		c.ErrorControl = ErrorNormal
-	}
 	if c.ServiceType == 0 {
 		c.ServiceType = windows.SERVICE_WIN32_OWN_PROCESS
 	}