singleflight: fix flaky TestForget
There can be a race condition in current TestForget, that said when
"close(secondCh)" is executed, the second goroutine will be finished
immediately, causing the third "g.Do" is evaluated.
To fix this, we change to use "g.DoChan" for both second and third. In
second, we block to make sure it's still running at the time we call
third. after then we unblock second and verify the result.
Fixes golang/go#42092
Change-Id: I980fdf109a531e2b7a74c8149b4fcaa338775e08
Reviewed-on: https://go-review.googlesource.com/c/sync/+/263877
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
diff --git a/singleflight/singleflight_test.go b/singleflight/singleflight_test.go
index a9ad17f..3e51203 100644
--- a/singleflight/singleflight_test.go
+++ b/singleflight/singleflight_test.go
@@ -97,70 +97,41 @@
func TestForget(t *testing.T) {
var g Group
- var firstStarted, firstFinished sync.WaitGroup
+ var (
+ firstStarted = make(chan struct{})
+ unblockFirst = make(chan struct{})
+ firstFinished = make(chan struct{})
+ )
- firstStarted.Add(1)
- firstFinished.Add(1)
-
- firstCh := make(chan struct{})
go func() {
g.Do("key", func() (i interface{}, e error) {
- firstStarted.Done()
- <-firstCh
- firstFinished.Done()
+ close(firstStarted)
+ <-unblockFirst
+ close(firstFinished)
return
})
}()
+ <-firstStarted
+ g.Forget("key")
- firstStarted.Wait()
- g.Forget("key") // from this point no two function using same key should be executed concurrently
+ unblockSecond := make(chan struct{})
+ secondResult := g.DoChan("key", func() (i interface{}, e error) {
+ <-unblockSecond
+ return 2, nil
+ })
- var secondStarted int32
- var secondFinished int32
- var thirdStarted int32
+ close(unblockFirst)
+ <-firstFinished
- secondCh := make(chan struct{})
- secondRunning := make(chan struct{})
- go func() {
- g.Do("key", func() (i interface{}, e error) {
- defer func() {
- }()
- atomic.AddInt32(&secondStarted, 1)
- // Notify that we started
- secondCh <- struct{}{}
- // Wait other get above signal
- <-secondRunning
- <-secondCh
- atomic.AddInt32(&secondFinished, 1)
- return 2, nil
- })
- }()
-
- close(firstCh)
- firstFinished.Wait() // wait for first execution (which should not affect execution after Forget)
-
- <-secondCh
- // Notify second that we got the signal that it started
- secondRunning <- struct{}{}
- if atomic.LoadInt32(&secondStarted) != 1 {
- t.Fatal("Second execution should be executed due to usage of forget")
- }
-
- if atomic.LoadInt32(&secondFinished) == 1 {
- t.Fatal("Second execution should be still active")
- }
-
- close(secondCh)
- result, _, _ := g.Do("key", func() (i interface{}, e error) {
- atomic.AddInt32(&thirdStarted, 1)
+ thirdResult := g.DoChan("key", func() (i interface{}, e error) {
return 3, nil
})
- if atomic.LoadInt32(&thirdStarted) != 0 {
- t.Error("Third call should not be started because was started during second execution")
- }
- if result != 2 {
- t.Errorf("We should receive result produced by second call, expected: 2, got %d", result)
+ close(unblockSecond)
+ <-secondResult
+ r := <-thirdResult
+ if r.Val != 2 {
+ t.Errorf("We should receive result produced by second call, expected: 2, got %d", r.Val)
}
}
