commit | f6206b3b2d8d1632fba8ea7850c478fca35cb588 | [log] [tgz] |
---|---|---|
author | Filippo Valsorda <hi@filippo.io> | Thu Feb 08 16:09:53 2018 +0000 |
committer | Filippo Valsorda <hi@filippo.io> | Thu Feb 08 16:19:54 2018 +0000 |
tree | 58a85518f75d0d7f3bc0d1f26df2b4b352ed9e12 | |
parent | 388d6c1f875e2c10838bea079820549c8e070d07 [diff] |
filippo: create github.txt Couldn't wait testing the new shiny GitHub PR integration. Change-Id: Id6f732f66a48b4d842dfef359783a9f7981faefd GitHub-Last-Rev: 23cf5d21d0b2d203f9622b5c87c7fb2c7cb2b6c0 GitHub-Pull-Request: golang/scratch#17 Reviewed-on: https://go-review.googlesource.com/92875 Reviewed-by: Filippo Valsorda <hi@filippo.io>
This repository is mainly for use by people learning how to use Gerrit and contribute to Go.
Click here for a tutorial on how to get started with a contribution to this repository.
A fuller, text-based tutorial based around the core Go project can be found here.
Add a folder with your username, and put a main function in there. You can put whatever you want in your main function; see the existing directories for examples.
All files should have the standard licensing header, and add appropriate documentation see the other files in this repository for an example.
If you have needed to change a Github pull request, you probably just added a second commit with the requested changes and pushed it. By contrast, all changes opened in Gerrit are a single commit, which means you need to amend your commit if the reviewer requests feedback.
To amend a previous commit, run git add (list of files you changed)
to add your changes, then run git commit --amend
to amend the commit to add new data. Your commit message should still summarize the entire commit (“Add kevinburke/main.go”), not just the change a reviewer asked for (“Fix typo”).
After you amend the commit, re-run git codereview mail
to push that change to the server. Then in the Gerrit UI, find the in-line comments left by your reviewer, click “Done”, go back to the main PR page, and click “Reply” => “Send” to tell your reviewer that you've addressed your feedback.
Once you get a “Code-Review: +2” from a Go contributor, your change will be merged!
Gerrit is not easy to get started with, and we want to help you out. If you are having trouble with Gerrit, contact the golang-devexp mailing list for help!