| commit | 38b40c0e2b9e3a62d9a99d62fa70595a5f68e6c9 | [log] [tgz] |
|---|---|---|
| author | Joshua Sing <joshua@hypera.dev> | Sun Nov 19 02:19:34 2023 +1100 |
| committer | Gopher Robot <gobot@golang.org> | Thu Feb 29 18:41:27 2024 +0000 |
| tree | bb7a19b85a177d261ff47a4fc2be127fac53389c | |
| parent | 0e3f2836ef3e230ced34f5550aa937610e076531 [diff] |
git-codereview: improve haveGerritInternal Use url.Parse and check URL components rather than performing imprecise string matching. This addresses a bug where git-codereview does not work when the Git origin ends with a forward slash. Note that the check for 'github.com' has been removed since the test for '.googlesource.com' already excludes it. Change-Id: I083bccdbacf2152cbfddd2407fb20afa47c8e91e Reviewed-on: https://go-review.googlesource.com/c/review/+/543495 Reviewed-by: Carlos Amedee <carlos@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Run-TryBot: Joel Sing <joel@sing.id.au>
The git-codereview tool is a command-line tool for working with Gerrit.
The easiest way to install is to run go install golang.org/x/review/git-codereview@latest. You can also manually git clone the repository to $GOPATH/src/golang.org/x/review.
Run git codereview hooks to install Gerrit hooks for your git repository.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the review repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/review:” in the subject line, so it is easy to find.