tree bb7a19b85a177d261ff47a4fc2be127fac53389c
parent 0e3f2836ef3e230ced34f5550aa937610e076531
author Joshua Sing <joshua@hypera.dev> 1700320774 +1100
committer Gopher Robot <gobot@golang.org> 1709232087 +0000

git-codereview: improve haveGerritInternal

Use url.Parse and check URL components rather than performing imprecise
string matching. This addresses a bug where git-codereview does not work
when the Git origin ends with a forward slash.

Note that the check for 'github.com' has been removed since the test for
'.googlesource.com' already excludes it.

Change-Id: I083bccdbacf2152cbfddd2407fb20afa47c8e91e
Reviewed-on: https://go-review.googlesource.com/c/review/+/543495
Reviewed-by: Carlos Amedee <carlos@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Joel Sing <joel@sing.id.au>